I submitted my plugin WP People Pop a few days ago to the WordPress.org system. I waited anxiously to get my response and see if it was approved. Well, this morning I got my answer, no. No, it has not been approved yet.
I read through the email and turns out you aren’t supposed to include libraries with your plugin that WordPress already provides in its core. I was using jQuery UI to handle some interface items and I included the whole UI package in my plugin’s directory.
I checked out the list of included libraries and turns out you can’t just include all of jQuery UI but you have to include each component you need, seperately. I guess this makes sense, why have more code included than necessary?
I resubmitted with changes. Oh, they also made sure to mention I need to clear the now unused js files out. Email below:
There are issues with your plugin code. Please read this ENTIRE email, address all listed issues, and reply to this email with your corrected code attached. It is required for you to read and reply to these emails, and failure to do so will result in your plugin being rejected.
## Including jquery files (or calling them remotely)
WordPress includes its own version of jquery and many other similar JS files, which have all been rigorously tested with WP and many of the most common plugins. In order to provide the best compatibility and experience for our users, we ask that you not package your own (especially not an older version) and instead use wp_enqueue_script() to pull in WordPress’s version.
Please review http://codex.wordpress.org/
Function_Reference/wp_enqueue_ script and update your plugin accordingly. You need to both change your code to use our jquery as well as remove the unused files. Remember! Keeping unused files out of your plugins makes them smaller and less potentially vulnerable! if you have any jquery files included in your plugin that WP core has, just delete them. Offloading jquery js, css, and other scripts to Google (or jquery.com or anywhere else frankly) is similarly disallowed for the same reasons, but also because you’re introducing an unnecessary dependency on another site. If the file you’re trying to use isn’t a part of WordPress Core, then you should include it -locally- in your plugin, not remotely.
If your code doesn’t work with the built-in versions of jquery, it’s most likely a no conflict issue. If you can’t guess, we -really- want you to use our JS files, and if you can’t, we need to know why so we can fix things for everyone. If you’re just including it because you want to support old versions of WP, or because you think they may not have jquery, please don’t. If they don’t have the default jquery, a lot more than your plugin will break. And if they’re on older versions of WordPress, they need to upgrade, and we don’t recommend you support anything except the most recent version of WP and one release back.
WordPress already has jquery and jquery UI included. Do not include your own. The CSS is fine, but the JS is not.
—-
Please make sure you’ve addressed ALL issues brought up in this email. When you’ve corrected your code, reply to this email with the updated code attached as a zip, or provide a link to the new code for us to review. If you have questions, concerns, or need clarification, please reply to this email and just ask us.
